DESCRIPTION

Bug 412927

Context menu can be corrupted if there is an invalid property tester

Change-Id: Ie6bbf4f1173abd56d6ce1152c81259415ecd3e73
Signed-off-by: Lucia Hendrix xxx@xxx.xxx


COMMENTS

author: Slade Moran
date: 2013-07-24 18:32:08.000000000

Patch Set 3: Code-Review-1

(4 comments)

I've included 4 inline comments.

Line:7, /COMMIT_MSG -> Our comment format is from bugzilla: 

Bug 412927 - Context menu can be corrupted if there is an invalid property tester

But it won't hold up accepting the contribution as long as the Bug # is there.

Line:233, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ContributionsAnalyzer.java -> eContext can be made a final parameter so you don't need the other ExpressionContext.

Line:234, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ContributionsAnalyzer.java -> This can be made "final Expression ref;" and then you don't need the other final variable

Line:250, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ContributionsAnalyzer.java -> These 2 finals can be removed.

-------------------------------------
