DESCRIPTION

Bug 394013 - Unable to get dropdown menu in ToolItem to display

COMMENTS

author: Addison Irwin
date: 2013-06-27 09:42:13.000000000

Patch Set 1:

The patch has been tested for dynamic menu contribution, using the attached sample project as well as the static one, using the *.e4xmi file

-------------------------------------
author: Teagan Marsh
date: 2013-06-28 13:29:14.000000000

Patch Set 1:

(3 comments)

Shouldn't have System.err.println()s — and I'm not sure we want to accommodate the case of returning something other than a Menu for now.

There seems to be a logic error unrelated to your change in DCI.

Line:462, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolItemRenderer.java -> Seems like a candidate for an assertion here.

Line:442, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> An aside: should this be setting the OWNING_ME to mmenu (the model element)?

Line:451, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> Seems like a candidate for an assertion

-------------------------------------
author: Addison Irwin
date: 2013-06-28 13:42:33.000000000

Patch Set 1:

The patch bases on the HandledContributionItem.getMenu method. The method skips setting the OWNING_ME data for some reasons. Do you want to set this data anyway?

I will replace the System.err with the proper logger invocation

thanks,
Daniel

-------------------------------------
