DESCRIPTION

[403083] xxx@xxx.xxx is not optional

COMMENTS

author: Slade Moran
date: 2013-03-15 14:26:28.000000000

Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

This change needs to be rebased on https://git.eclipse.org/r/#/c/11195/ and then the comments addressed.

Line:170, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java -> Needs to be rebased on https://git.eclipse.org/r/#/c/11195/

Line:173, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java -> I wouldn't check in this much detail if xxx@xxx.xxx method is missing.  Instead, log the error in all cases and continue the processling loop.

Line:228, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java -> This could then be removed

Line:95, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerHideProcessor.java -> Needs to be rebased on https://git.eclipse.org/r/#/c/11195/

-------------------------------------
