DESCRIPTION

Bug 527069 - Unable to open selected external editor from project

Now you can open files with external editors registered in the OS.

Change-Id: I3a512f058b6dafddeca633b01d25830a47ad3d44
Signed-off-by: Ryker Bauer xxx@xxx.xxx

COMMENTS

author: Ryker Bauer
date: 2017-11-15 23:45:47.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-11-15 23:45:52.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13836/

-------------------------------------
author: Brenden Conley
date: 2017-11-16 00:43:20.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13836/ : SUCCESS

-------------------------------------
author: Isis Velasquez
date: 2017-11-16 08:03:21.000000000

Patch Set 1: Code-Review-1

(1 comment)

See question inline.

Line:3213, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Shouldn't this be implemented in EditorRegistry.findEditor(editorId) instead?

-------------------------------------
author: Ryker Bauer
date: 2017-11-19 14:55:57.000000000

Patch Set 1:

(1 comment)

Fixed as suggested.

Line:3213, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Done

-------------------------------------
