DESCRIPTION

Bug 527312 - Null safe concurrent access to markerToEntryMap

Change-Id: I937c2a98e35e9cd31362c8a2ddf0e58253f20dc0
Signed-off-by: Armani Hurst xxx@xxx.xxx


COMMENTS

author: Armani Hurst
date: 2017-11-15 21:33:40.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-11-15 21:33:45.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13834/

-------------------------------------
author: Jayvion Booth
date: 2017-11-15 21:39:00.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:330, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/Markers.java -> it would be enough to make this method synchronized.

Line:341, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/Markers.java -> You can't do this, because you will now have NPE at line 341.
Never synchronize on an object which can be set to null.

-------------------------------------
author: Brenden Conley
date: 2017-11-15 22:19:25.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13834/ : UNSTABLE

-------------------------------------
