DESCRIPTION

Bug 525343 - importPreferences removes preferenceChangedListeners

Change-Id: I8d8c75b76bf288ea2093f7d742be3a63c2d8fb62
Signed-off-by: Leah Wolf xxx@xxx.xxx


COMMENTS

author: Leah Wolf
date: 2017-10-17 19:22:35.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-10-17 19:22:41.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13699/

-------------------------------------
author: Isis Velasquez
date: 2017-10-17 19:26:25.000000000

Patch Set 2:

(1 comment)

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/wizards/preferences/messages.properties -> Need a mnemonic, best is to place it on R (&Restart)

-------------------------------------
author: Leah Wolf
date: 2017-10-17 19:30:05.000000000

Patch Set 2:

(1 comment)

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/wizards/preferences/messages.properties -> On the Cancel as well?

-------------------------------------
author: Isis Velasquez
date: 2017-10-17 19:34:40.000000000

Patch Set 2:

(1 comment)

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/wizards/preferences/messages.properties -> Good question, leading to a good improvement: do not redefine the label for the cancel button, just use IDialogConstants.CANCEL_LABEL defined by JFace

-------------------------------------
author: Brenden Conley
date: 2017-10-17 20:01:13.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13699/ : FAILURE

-------------------------------------
