DESCRIPTION

Bug 522418 - Quick Access result popup should be bigger

Change-Id: Id755dec99b8c72e3fd52fc72f8f36e64815279e5
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2017-09-19 12:07:31.000000000

Uploaded patch set 2: Patch Set 1 was rebased.

-------------------------------------
author: Jayvion Booth
date: 2017-09-19 12:34:01.000000000

Patch Set 2:

(3 comments)

Line:492, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java -> Can we please extract this, the code will be more readable.

Line:495, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java -> nearly all window height?

Line:496, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java -> Windows placed like stripes in either horizontal/vertical direction can have "unexpected" dimensions, so I think we should have minimum / maximum checks.

It makes no sense for a dialog to be smaller 300 pixels width and 200 pixels height but should be not more then a *display* width x height (not the shell!).

-------------------------------------
author: Isis Velasquez
date: 2017-09-19 12:37:10.000000000

Patch Set 2:

(1 comment)

Line:495, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java -> with a regular laptop screen, and Eclipse fullscreen, this is actually a comfortable value.

-------------------------------------
author: Isis Velasquez
date: 2017-09-19 12:39:42.000000000

Patch Set 2:

(1 comment)

Line:496, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/quickaccess/SearchField.java -> Isn't the "max" part covered by the `getConstrainedShellBounds` method below?

-------------------------------------
author: Brenden Conley
date: 2017-09-19 13:01:19.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13520/

-------------------------------------
author: Brenden Conley
date: 2017-09-19 13:29:37.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13520/ : SUCCESS

-------------------------------------
