DESCRIPTION

Bug 517068 - key binding conflicts check for enabled commands

Invoking a keybinding wasn't taking into account whether command is
executable or not. This can be annoying in case of multiple commands
bound to the same binding: user got asked to choose which command to
invoke, but some of those commands were not executable and resulted in
an error message to user.
With a filter to only use executable commands, in most cases, we
shouldn't even see a pop-up as commands on a same shortcut are usually
mutually exclusive, and in case the pop-up shows up, it would only
propose commands that can run properly.

Cherry-picked from 3b4b24c0ed0ab0ea759805b35222bc72837b8234

Change-Id: Ic9d1decb505240e726f9faa067f4a1ecf6d1556e
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2017-08-23 05:52:09.000000000

Patch Set 4: Patch Set 3 was rebased

-------------------------------------
author: Brenden Conley
date: 2017-08-23 05:52:18.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13378/

-------------------------------------
author: Brenden Conley
date: 2017-08-23 06:18:12.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13378/ : SUCCESS

-------------------------------------
author: Isis Velasquez
date: 2017-08-23 08:30:43.000000000

Patch Set 4:

@Dani: can you please review this change and approve it for 4.7.1.RC2?

-------------------------------------
author: Sebastian Porter
date: 2017-08-23 12:40:20.000000000

Patch Set 4:

xxx@xxx.xxx can you please review this change and approve it for
 > 4.7.1.RC2?

Yes, I will take a look.

-------------------------------------
