DESCRIPTION

Bug 520187 - setToDefault - compare values with Objects.equals()

Change-Id: Ie118ce7acc7469e540ba1315bd68ff245006fb51
Signed-off-by: Armani Hurst xxx@xxx.xxx


COMMENTS

author: Armani Hurst
date: 2017-07-26 09:26:20.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
author: Brenden Conley
date: 2017-07-26 09:26:28.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13284/

-------------------------------------
author: Zaid Mosley
date: 2017-07-26 09:41:58.000000000

Patch Set 2:

(1 comment)

Line:536, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/preferences/ScopedPreferenceStore.java -> Why is Objects.equals better than oldValue.equals(defaultValue)?

-------------------------------------
author: Brenden Conley
date: 2017-07-26 10:00:24.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13284/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-07-27 10:00:52.000000000

Patch Set 2:

Karsten, can you answer my question?

-------------------------------------
author: Armani Hurst
date: 2017-07-27 15:21:36.000000000

Patch Set 2:

(1 comment)

> Karsten, can you answer my question?

Because oldValue can be null and Objects.equals checks that and also checks for identity

Line:536, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/preferences/ScopedPreferenceStore.java -> Because oldValue can be null and Objects.equals checks that and also checks for identity

-------------------------------------
