DESCRIPTION

JVMCBC-456: Polish JsonPointer and JsonPointerTree.

Motivation
----------
This changeset doesn't change any of the functionality, it just
cleanes up the code, adds javadoc and a couple of test cases
for the JsonPointer.

Change-Id: I1adf4f60efcf5ba7f3a87f4ad5e8dae62af9e584


COMMENTS

author: Natasha Sullivan
date: 2017-08-31 12:51:10.202000000

Uploaded patch set 1.

-------------------------------------
author: Hugo Blankenship
date: 2017-08-31 12:51:17.866000000

Patch Set 1:

Build Started http://sdkbuilds.sc.couchbase.com/job/couchbase-jvm-core-test/56/

-------------------------------------
author: Hugo Blankenship
date: 2017-08-31 12:52:43.820000000

Patch Set 1: Verified+1

Build Successful 

http://sdkbuilds.sc.couchbase.com/job/couchbase-jvm-core-test/56/ : SUCCESS

-------------------------------------
author: Carmen Buckley
date: 2017-08-31 19:44:03.233000000

Patch Set 1:

(1 comment)

Line:148, src/main/java/com/couchbase/client/core/utils/yasjl/JsonPointer.java -> Potential StringIndexOutOfBoundsException if refTokens is empty list:

  System.out.println(new JsonPointer(new ArrayList<String>()));

Should  the constructor throw IllegalArgumentException for empty list?

-------------------------------------
author: Cory Peck
date: 2017-09-01 08:33:33.816000000

Patch Set 1: Code-Review+2

-------------------------------------
author: Cory Peck
date: 2017-09-01 08:34:47.049000000

Removed Code-Review+2 by Cory Peck xxx@xxx.xxx


-------------------------------------
author: Natasha Sullivan
date: 2017-09-01 09:27:27.329000000

Patch Set 1:

(1 comment)

Line:148, src/main/java/com/couchbase/client/core/utils/yasjl/JsonPointer.java -> you are right - thanks! I'll do the fix in a follow up commit otherwise I get into rebase hell :D

-------------------------------------
author: Cory Peck
date: 2017-09-01 09:28:27.050000000

Patch Set 1: Code-Review+2

-------------------------------------
