DESCRIPTION

JVMCBC-384 Add XATTR support

Change-Id: I1a4fac8662b7a1a44ac0519b0200b45478dc2e32


COMMENTS

author: Marques Ellis
date: 2017-01-20 04:25:24.129000000

Uploaded patch set 4: Patch Set 3 was rebased.

-------------------------------------
author: Natasha Sullivan
date: 2017-01-20 12:37:26.457000000

Patch Set 4:

(2 comments)

Line:84, src/main/java/com/couchbase/client/core/message/kv/subdoc/simple/AbstractSubdocMutationRequest.java -> should the illegal argument exception be triggered here too like below? are the setters needed at all?

Line:573, src/main/java/com/couchbase/client/core/endpoint/kv/KeyValueHandler.java -> does all this code also need to be readded to the multi* actions?

-------------------------------------
author: Marques Ellis
date: 2017-02-06 23:05:40.736000000

MISMATCHED INLINE COMMENT
Line:84, src/main/java/com/couchbase/client/core/message/kv/subdoc/simple/AbstractSubdocMutationRequest.java -> No, this is just constructor initialization from the sub class, not a overload, the setters are how the values should be set as described by rfc. It isn't finalized yet.

-------------------------------------
author: Marques Ellis
date: 2017-02-06 23:05:40.736000000

MISMATCHED INLINE COMMENT
Line:573, src/main/java/com/couchbase/client/core/endpoint/kv/KeyValueHandler.java -> No multi works a bit differently, the flags are added while

-------------------------------------
