DESCRIPTION

JVMCBC-255: Change CoreEnvironment#shutdown to blocking.

Motivation
----------
Deprecated since 2.2.0, the shutdown method is now changed from async
to sync, leading to more straightforward behavior and less bugs in the
field (like users forgetting to block on the call and therefore having
an unclean shutdown).

Modifications
-------------
In the process of moving shutdown to sync, a few other things had
to be changed as well:

 - The disconnectTimeout has been moved from the CouchbasEnvironment
   down to the CoreEnvironment since we need one on the now blocking
   shutdown method. The java-client will be modified to take this
   into account as well.
 - Because .timeout() can't be properly used, the Blocking utilities
   have been moved over from java-client as well and can now be removed
   from there if needed. Reason is that if .timeout() is chained in,
   there are thread still pending and the shutdown tests start to
   fail.

Result
------
Easier access to blocking environment shutdown and sane defaults.

Change-Id: Ic68c236d8917a71baa5b72082da6dcbafa2ee5dd


COMMENTS

author: Natasha Sullivan
date: 2016-05-10 05:13:30.511000000

Uploaded patch set 1.

-------------------------------------
author: Natasha Sullivan
date: 2016-05-10 05:17:57.781000000

Patch Set 1: Verified+1

-------------------------------------
author: Estrella Humphrey
date: 2016-05-10 07:29:23.535000000

Patch Set 1:

(2 comments)

Line:40, src/main/java/com/couchbase/client/core/utils/Blocking.java -> maybe add that as a comment (in java-client between 2.0.2 and 2.3.0) and have it xxx@xxx.xxx 1.3.0

Line:103, src/main/java/com/couchbase/client/core/utils/Blocking.java -> same as above, change the xxx@xxx.xxx and comment that it was in java-client between 2.2.0-2.3.0

-------------------------------------
author: Gerrit Code Review
date: 2016-05-10 07:50:46.128000000

Change has been successfully cherry-picked as abb86c3c49773dd5444f421b7c2b1b1bced00d96 by Natasha Sullivan

-------------------------------------
