DESCRIPTION

Log errors on reconnect triggered by channelInactive

Change-Id: Idc8a28cfe2fce581fed2249e0c525423e0f03a8e


COMMENTS

author: Natasha Sullivan
date: 2016-03-29 12:34:32.929000000

Uploaded patch set 1.

-------------------------------------
author: Estrella Humphrey
date: 2016-03-30 07:59:53.572000000

Patch Set 1:

(1 comment)

Line:438, src/main/java/com/couchbase/client/core/endpoint/AbstractEndpoint.java -> what about doOnError? (this is sensibly the same as the underlying observable is a Subject... maybe explicitly subscribing is a good idea though)

-------------------------------------
author: Estrella Humphrey
date: 2016-03-30 08:00:32.071000000

Patch Set 1: Code-Review+1

see comment inline, not a blocker though

-------------------------------------
author: Natasha Sullivan
date: 2016-03-30 08:02:35.651000000

Patch Set 1:

(1 comment)

Line:438, src/main/java/com/couchbase/client/core/endpoint/AbstractEndpoint.java -> I wanted to explicitly subscribe, because otherwise you get the onErrorNotImplemented in the logs?

-------------------------------------
author: Estrella Humphrey
date: 2016-03-30 08:34:30.254000000

Patch Set 1: Code-Review+2

-------------------------------------
author: Natasha Sullivan
date: 2016-03-30 08:36:49.822000000

Patch Set 1: Verified+1

-------------------------------------
author: Gerrit Code Review
date: 2016-03-30 08:36:52.442000000

Change has been successfully cherry-picked as c37a5737cbcb6660ab3bb6007aadcc88d612bf91

-------------------------------------
