DESCRIPTION

JVMCBC-225: Expose partition in DCPResponse

Motivation
----------
To properly serialize state, DCPResponse should carry partition index.

Modification
------------
Expose partition in DCPResonses

Result
------
Caller can now extract partition index from StreamRequestResponse and
update stream state correctly

Change-Id: Id91e436fb0752deccf06345c9fb665c45bf5be13


COMMENTS

author: Cory Peck
date: 2015-07-24 08:48:20.536000000

Uploaded patch set 1.

-------------------------------------
author: Cory Peck
date: 2015-07-24 08:49:51.961000000

Patch Set 1: Verified+1

-------------------------------------
author: Estrella Humphrey
date: 2015-07-24 08:58:36.037000000

Patch Set 1: Code-Review+2

(1 comment)

Line:48, src/main/java/com/couchbase/client/core/message/dcp/DCPResponse.java -> maybe document id is expected to be >= 0

-------------------------------------
author: Estrella Humphrey
date: 2015-07-24 08:59:10.046000000

Patch Set 1:

looks good, the javadoc could have 1 improvement but it is up to you (see comment)

-------------------------------------
author: Cory Peck
date: 2015-07-24 09:02:58.930000000

Patch Set 1:

(1 comment)

Line:48, src/main/java/com/couchbase/client/core/message/dcp/DCPResponse.java -> I think it is clear, also it is not documented in BinaryRequest either

https://github.com/couchbase/couchbase-jvm-core/blob/master/src/main/java/com/couchbase/client/core/message/kv/BinaryRequest.java#L48-L54

-------------------------------------
author: Estrella Humphrey
date: 2015-07-24 09:57:19.364000000

Patch Set 1:

fair enough, go ahead and submit then ;)

-------------------------------------
author: Gerrit Code Review
date: 2015-07-24 10:00:13.411000000

Change has been successfully cherry-picked as 582db367044e60fa6f1b64ac4bbd872ff3dc7d09

-------------------------------------
